Discussion:
[cryptopp-users] Remove Thread and Socket classes
Jeffrey Walton
2018-08-17 03:11:54 UTC
Permalink
Hi Everyone,

We have an open issue for removing Thread and Socket classes. Also see
https://github.com/weidai11/cryptopp/issues/208.

I think Denis Bider summed it up nicely in the report. Effectively he says
we should focus on core capabilities and avoid some of the less frequently
used extras like Sockets, Thread Local Storage and Pipes. I personally like
the position because it reduces code clutter and avoids some points of
failure.

I checked in the removal on my testing branch at
https://github.com/noloader/cryptopp . If all goes well I would like to
merge it soon.

I plan on moving Remove Thread and Socket classes to the Patch Page on the
wiki. If anyone needs them they will be located there.

Are there any objections to removing Remove Thread and Socket classes?
--
You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users.
---
You received this message because you are subscribed to the Google Groups "Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Jeffrey Walton
2018-08-18 03:56:21 UTC
Permalink
Post by Jeffrey Walton
Hi Everyone,
We have an open issue for removing Thread and Socket classes. Also see
https://github.com/weidai11/cryptopp/issues/208.
I think Denis Bider summed it up nicely in the report. Effectively he says
we should focus on core capabilities and avoid some of the less frequently
used extras like Sockets, Thread Local Storage and Pipes. I personally like
the position because it reduces code clutter and avoids some points of
failure.
I checked in the removal on my testing branch at
https://github.com/noloader/cryptopp . If all goes well I would like to
merge it soon.
I plan on moving Remove Thread and Socket classes to the Patch Page on the
wiki. If anyone needs them they will be located there.
Are there any objections to removing Remove Thread and Socket classes?
Merged at https://github.com/weidai11/cryptopp/pull/703 .

Jeff
--
You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users.
---
You received this message because you are subscribed to the Google Groups "Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Jeffrey Walton
2018-08-18 15:07:13 UTC
Permalink
Post by Jeffrey Walton
Post by Jeffrey Walton
Hi Everyone,
We have an open issue for removing Thread and Socket classes. Also see
https://github.com/weidai11/cryptopp/issues/208.
I think Denis Bider summed it up nicely in the report. Effectively he
says we should focus on core capabilities and avoid some of the less
frequently used extras like Sockets, Thread Local Storage and Pipes. I
personally like the position because it reduces code clutter and avoids
some points of failure.
I checked in the removal on my testing branch at
https://github.com/noloader/cryptopp . If all goes well I would like to
merge it soon.
I plan on moving Remove Thread and Socket classes to the Patch Page on
the wiki. If anyone needs them they will be located there.
Are there any objections to removing Remove Thread and Socket classes?
Merged at https://github.com/weidai11/cryptopp/pull/703 .
We added a wiki page as a sign post at
https://www.cryptopp.com/wiki/ThreadLocalStorage . ThreadLocalStorage
seemed most important as it was wired into the FIPS gear. Everything else
was mostly stand-alone.

The wiki page provides a list of affected files and classes, and provides a
brief discussion of the reasons why.

Jeff
--
You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users.
---
You received this message because you are subscribed to the Google Groups "Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Andrew Marlow
2018-08-21 09:39:06 UTC
Permalink
Post by Jeffrey Walton
Post by Jeffrey Walton
Post by Jeffrey Walton
I checked in the removal on my testing branch at
https://github.com/noloader/cryptopp . If all goes well I would like to
merge it soon.
I plan on moving Remove Thread and Socket classes to the Patch Page on
the wiki. If anyone needs them they will be located there.
Are there any objections to removing Remove Thread and Socket classes?
Merged at https://github.com/weidai11/cryptopp/pull/703 .
We added a wiki page as a sign post at
https://www.cryptopp.com/wiki/ThreadLocalStorage . ThreadLocalStorage
seemed most important as it was wired into the FIPS gear. Everything else
was mostly stand-alone.
The wiki page provides a list of affected files and classes, and provides
a brief discussion of the reasons why.
Does this mean that FIPS support is no more after this change? I don't
mind, I just need to know.

-Andrew M.
--
You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users.
---
You received this message because you are subscribed to the Google Groups "Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Jeffrey Walton
2018-08-21 10:09:15 UTC
Permalink
Post by Jeffrey Walton
...
We added a wiki page as a sign post at
https://www.cryptopp.com/wiki/ThreadLocalStorage . ThreadLocalStorage
seemed most important as it was wired into the FIPS gear. Everything else
was mostly stand-alone.
The wiki page provides a list of affected files and classes, and provides
a brief discussion of the reasons why.
Does this mean that FIPS support is no more after this change? I don't mind,
I just need to know.
The Crypto++ FIPS validation was withdrawn by the CMVP when it place
Crypto++ on the Historical Validation List. Also see Denis Bider's
report at https://github.com/weidai11/cryptopp/issues/149 .

Jeff
--
You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users.
---
You received this message because you are subscribed to the Google Groups "Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+***@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Loading...